Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If running on a RPI 1 or single core Pi then default to the TG1 menu as the home menu #481

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

diyelectromusic
Copy link
Collaborator

When running on a single core RPi there is only one tone generator, so this change will get the menu system to default to the TG1 menu rather than always having to select TG1 before changing anything.

Note: the higher level menu hasn't gone away and can still be reached by selecting "back" - the highest level menu structure is still: TG1 - Effects - Performance.

But with this change the "home" menu is at the TG1 level, showing "Voice" which is a lot more convenient when only one TG is present.

@probonopd
Copy link
Owner

Undecided about this.

I see that this may make it easier, but it would make documentation/tutorials harder because now we would have different behavior for the different models.

@diyelectromusic
Copy link
Collaborator Author

I don't see that tbh. And I suspect the number of people running on a Pi V1 is probably not that great. From personal experience, the additional level of menu for non-existent other TGs really doesn't make much sense.

And if someone does happen to be using a Pi 1 and is following the tutorial on the wiki, it is already not really accurate as it talks about TG2, etc and the effects menu which don't apply.

And the menu presented is shown in the graphic just two below the first, so I really don't think it is a major issue compared to the much more meaningful "home" location.

Kevin

@probonopd
Copy link
Owner

OK, please do update the wiki with a note for RPi 1 and Zero (but not Zero 2) users. Thanks!

@probonopd probonopd merged commit 00e2f10 into probonopd:main Apr 18, 2023
@diyelectromusic
Copy link
Collaborator Author

Done.

@diyelectromusic diyelectromusic deleted the tg1homemenu branch April 18, 2023 19:59
@probonopd
Copy link
Owner

Thank you Kevin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants